warren830 commented on code in PR #3838:
URL:
https://github.com/apache/incubator-devlake/pull/3838#discussion_r1037746883
##########
plugins/jenkins/tasks/build_collector.go:
##########
@@ -49,22 +49,21 @@ func CollectApiBuilds(taskCtx core.SubTaskContext)
errors.Error {
RawDataSubTaskArgs: helper.RawDataSubTaskArgs{
Params: JenkinsApiParams{
ConnectionId: data.Options.ConnectionId,
- JobName: data.Options.JobName,
- JobPath: data.Options.JobPath,
+ FullName: data.Options.JobFullName,
},
Ctx: taskCtx,
Table: RAW_BUILD_TABLE,
},
ApiClient: data.ApiClient,
PageSize: 100,
- UrlTemplate: "{{ .Params.JobPath }}job/{{ .Params.JobName
}}/api/json",
+ UrlTemplate: fmt.Sprintf("%sjob/%s/api/json",
data.Options.JobPath, data.Options.JobName),
/*
(Optional) Return query string for request, or you can
plug them into UrlTemplate directly
*/
Query: func(reqData *helper.RequestData) (url.Values,
errors.Error) {
query := url.Values{}
treeValue := fmt.Sprintf(
-
"allBuilds[number,timestamp,duration,building,estimatedDuration,fullDisplayName,result,actions[lastBuiltRevision[SHA1,branch[name]],remoteUrls,mercurialRevisionNumber,causes[*]],changeSet[kind,revisions[revision]]]{%d,%d}",
+
"allBuilds[number,timestamp,duration,building,estimatedDuration,fullName,fullDisplayName,result,actions[lastBuiltRevision[SHA1,branch[name]],remoteUrls,mercurialRevisionNumber,causes[*]],changeSet[kind,revisions[revision]]]{%d,%d}",
Review Comment:
Great！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
