warren830 commented on code in PR #3838:
URL:
https://github.com/apache/incubator-devlake/pull/3838#discussion_r1037751474
##########
plugins/jenkins/tasks/build_cicd_convertor.go:
##########
@@ -105,10 +103,9 @@ func ConvertBuildsToCICD(taskCtx core.SubTaskContext) (err
errors.Error) {
}
jenkinsPipeline := &devops.CICDPipeline{
DomainEntity: domainlayer.DomainEntity{
- Id:
buildIdGen.Generate(jenkinsBuild.ConnectionId,
- jenkinsBuild.FullDisplayName),
+ Id:
buildIdGen.Generate(jenkinsBuild.ConnectionId, jenkinsBuild.FullName),
},
- Name: fmt.Sprintf(`%s%s`,
jenkinsBuild.JobPath, jenkinsBuild.JobName),
+ Name: jenkinsBuild.FullDisplayName,
Review Comment:
can we continue to use fullName here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
