[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4292: [Bitbucket] Pagination params and merged date on PRs

Wed, 01 Feb 2023 23:19:59 -0800 


likyh commented on code in PR #4292:
URL: 
https://github.com/apache/incubator-devlake/pull/4292#discussion_r1094126764


##########
backend/plugins/bitbucket/tasks/api_common.go:
##########
@@ -65,8 +65,8 @@ func CreateRawDataSubTaskArgs(taskCtx plugin.SubTaskContext, 
Table string) (*api
 func GetQuery(reqData *api.RequestData) (url.Values, errors.Error) {
        query := url.Values{}
        query.Set("state", "all")
-       query.Set("page", fmt.Sprintf("%v", reqData.Pager.Page))
-       query.Set("pagelen", fmt.Sprintf("%v", reqData.Pager.Size))
+       query.Set("start", fmt.Sprintf("%v", 
reqData.Pager.Page*reqData.Pager.Size))

Review Comment:
   https://jira.atlassian.com/browse/BCLOUD-19593
   
   <!-- 
https://api.bitbucket.org/2.0/repositories/likyh/likyhphp/pullrequests/1/commits?
 -->
   
   
![image](https://user-images.githubusercontent.com/3294100/216256791-acf57200-a5a4-4677-9c26-c2902953e041.png)
   
   It looks like we can not build a query on the client and we can only request 
it one page by one page.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to