likyh commented on code in PR #4292:
URL:
https://github.com/apache/incubator-devlake/pull/4292#discussion_r1095652466
##########
backend/plugins/bitbucket/tasks/api_common.go:
##########
@@ -65,8 +65,8 @@ func CreateRawDataSubTaskArgs(taskCtx plugin.SubTaskContext,
Table string) (*api
func GetQuery(reqData *api.RequestData) (url.Values, errors.Error) {
query := url.Values{}
query.Set("state", "all")
- query.Set("page", fmt.Sprintf("%v", reqData.Pager.Page))
- query.Set("pagelen", fmt.Sprintf("%v", reqData.Pager.Size))
+ query.Set("start", fmt.Sprintf("%v",
reqData.Pager.Page*reqData.Pager.Size))
Review Comment:
https://github.com/apache/incubator-devlake/pull/4320 (not ready, just
preview)
Added a new pages `PageInOrder` to support this situation.
And I find the page token is the same when `pagelen` is the same. Maybe we
can write a map to translate page to page token instead of using `PageInOrder`.
（no matter which pr is）
when pagelen=100 page=2: nextPage=67sER
when pagelen=100 page=2: nextPage= znuod
……
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
