jrflga commented on code in PR #4292:
URL:
https://github.com/apache/incubator-devlake/pull/4292#discussion_r1094511053
##########
backend/plugins/bitbucket/tasks/api_common.go:
##########
@@ -65,8 +65,8 @@ func CreateRawDataSubTaskArgs(taskCtx plugin.SubTaskContext,
Table string) (*api
func GetQuery(reqData *api.RequestData) (url.Values, errors.Error) {
query := url.Values{}
query.Set("state", "all")
- query.Set("page", fmt.Sprintf("%v", reqData.Pager.Page))
- query.Set("pagelen", fmt.Sprintf("%v", reqData.Pager.Size))
+ query.Set("start", fmt.Sprintf("%v",
reqData.Pager.Page*reqData.Pager.Size))
Review Comment:
You're right; sorry for the change to start/limit. It's used on other
collections of routes on Bitbucket API.
Maybe we can change how pagination on `reqData` is mounted because it's
different depending on what API is used.
We have no access to the `next` property when building `GetQuery` function
in `NewApiCollector`, so we can't fetch the next page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
