klesh commented on code in PR #5411:
URL:
https://github.com/apache/incubator-devlake/pull/5411#discussion_r1223722632
##########
backend/plugins/github/impl/impl.go:
##########
@@ -95,53 +102,11 @@ func (p Github) Description() string {
}
func (p Github) SubTaskMetas() []plugin.SubTaskMeta {
- return []plugin.SubTaskMeta{
- tasks.CollectApiIssuesMeta,
- tasks.ExtractApiIssuesMeta,
- tasks.CollectApiPullRequestsMeta,
- tasks.ExtractApiPullRequestsMeta,
- tasks.CollectApiCommentsMeta,
- tasks.ExtractApiCommentsMeta,
- tasks.CollectApiEventsMeta,
- tasks.ExtractApiEventsMeta,
- tasks.CollectApiPullRequestCommitsMeta,
- tasks.ExtractApiPullRequestCommitsMeta,
- tasks.CollectApiPullRequestReviewsMeta,
- tasks.ExtractApiPullRequestReviewsMeta,
- tasks.CollectApiPrReviewCommentsMeta,
- tasks.ExtractApiPrReviewCommentsMeta,
- tasks.CollectApiCommitsMeta,
- tasks.ExtractApiCommitsMeta,
- tasks.CollectApiCommitStatsMeta,
- tasks.ExtractApiCommitStatsMeta,
- tasks.CollectMilestonesMeta,
- tasks.ExtractMilestonesMeta,
- tasks.CollectAccountsMeta,
- tasks.ExtractAccountsMeta,
- tasks.CollectAccountOrgMeta,
- tasks.ExtractAccountOrgMeta,
- tasks.CollectRunsMeta,
- tasks.ExtractRunsMeta,
- tasks.ConvertRunsMeta,
- tasks.CollectJobsMeta,
- tasks.ExtractJobsMeta,
- tasks.ConvertJobsMeta,
- tasks.EnrichPullRequestIssuesMeta,
- tasks.ConvertRepoMeta,
- tasks.ConvertIssuesMeta,
- tasks.ConvertIssueAssigneeMeta,
- tasks.ConvertCommitsMeta,
- tasks.ConvertIssueLabelsMeta,
- tasks.ConvertPullRequestCommitsMeta,
- tasks.ConvertPullRequestsMeta,
- tasks.ConvertPullRequestReviewsMeta,
- tasks.ConvertPullRequestLabelsMeta,
- tasks.ConvertPullRequestIssuesMeta,
- tasks.ConvertIssueCommentsMeta,
- tasks.ConvertPullRequestCommentsMeta,
- tasks.ConvertMilestonesMeta,
- tasks.ConvertAccountsMeta,
+ list, err :=
subtaskmeta_sorter.NewDependencySorter(tasks.SubTaskMetaList).Sort()
Review Comment:
Can we reuse the result from
https://github.com/apache/incubator-devlake/pull/5411/files#diff-5d9d2b5b08a579490b7eeaba1746905ca45123a978ec531bd584183eec384fbfR51
instead of sorting it twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
