chenggui53 commented on PR #5411: URL: https://github.com/apache/incubator-devlake/pull/5411#issuecomment-1608816069
hi @klesh , I've done a version, can you help to review it when you have time :) here are the changes i've done: 1. Add table-based dependency registration and sorting in plugin helper 2. Add register and table dependencies in github plugin 3. To avoid changes in the gitlab plugin, I've kept subtaskMeta dependencies code and i will update it in another new pr. Some restrictions are also introduced 1. If a subtask task category depends on another task to handle this table, then an temporary table dependency should be added to the dependency of this task to ensure that a single data table is processed before that, which I think is also very understandable to developers. e.g. like EnrichPullRequestIssuesMeta and ConvertPullRequestIssuesMeta in github plugin, they depends on PullReqeust task to process data in RAW_PULL_REQUEST_TABLE, so i added tool_layer in their table dependency With that changes, we can process subtask concurrency (like we discussed in pr #4896), I can submit a new PR after completing the subtask register changes to support concurrent execution of subtasks in plugins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
