klesh commented on code in PR #5411:
URL:
https://github.com/apache/incubator-devlake/pull/5411#discussion_r1223931990
##########
backend/plugins/github/tasks/pr_commit_collector.go:
##########
@@ -44,6 +48,7 @@ var CollectApiPullRequestCommitsMeta = plugin.SubTaskMeta{
EnabledByDefault: true,
Description: "Collect PullRequestCommits data from Github api,
supports both timeFilter and diffSync.",
DomainTypes: []string{plugin.DOMAIN_TYPE_CROSS,
plugin.DOMAIN_TYPE_CODE_REVIEW},
+ Dependencies: []*plugin.SubTaskMeta{&ExtractApiEventsMeta},
Review Comment:
I just realize that the `Dependencies` are defined based on the current
order which would work but is not accurate.
For example, the `CollectApiPullRequestCommitsMeta` should depend on the
`ExtractApiPullRequestMete` instead of `ExtractApiEventsMeta`.
Would you mind updating the code to reflect that? The trick is to identify
[which
table](https://github.com/apache/incubator-devlake/pull/5411/files#diff-124f6bf67e82ddaafdc0fb6d16ab9ed8afa26c0937a25b259046520ebe1ada4dR79)
is required in the collector as the `Input` parameter, and find out the
Extractor of the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
