klesh commented on code in PR #5411: URL: https://github.com/apache/incubator-devlake/pull/5411#discussion_r1267439493
########## backend/helpers/pluginhelper/subtaskmeta/sorter/table.go: ########## @@ -0,0 +1,74 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package sorter + +import ( + "github.com/apache/incubator-devlake/core/errors" + "github.com/apache/incubator-devlake/core/plugin" +) + +type TableSorter struct { + metas []*plugin.SubTaskMeta +} + +func NewTableSorter(metas []*plugin.SubTaskMeta) SubTaskMetaSorter { + return &TableSorter{metas: metas} +} + +func (d *TableSorter) Sort() ([]plugin.SubTaskMeta, errors.Error) { + return tableTopologicalSort(d.metas) +} + +func tableTopologicalSort(metas []*plugin.SubTaskMeta) ([]plugin.SubTaskMeta, errors.Error) { + constructedMetas := constructDependenciesByTable(metas) + return dependenciesTopologicalSort(constructedMetas) +} + +func constructDependenciesByTable(metas []*plugin.SubTaskMeta) []*plugin.SubTaskMeta { + // construct map by metas and their produced tables, the key is table, and value is metas + tableMetasMap := make(map[string][]*plugin.SubTaskMeta) + for _, item := range metas { + for _, tableItem := range item.ProductTables { + if value, ok := tableMetasMap[tableItem]; ok { + tableMetasMap[tableItem] = append(value, item) + } else { + tableMetasMap[tableItem] = []*plugin.SubTaskMeta{item} + } + } + } + // construct meta dependencies by meta.TableDependencies + for _, metaItem := range metas { + for _, tableItem := range metaItem.DependencyTables { Review Comment: It would be better to create a temporary `map` for each `metaItem` and reuse it for deduplication instead of creating one on each `append` ########## backend/helpers/pluginhelper/subtaskmeta/sorter/table_test.go: ########## @@ -0,0 +1,81 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package sorter + +import ( + "github.com/apache/incubator-devlake/core/errors" + "github.com/apache/incubator-devlake/core/plugin" + "reflect" + "testing" +) + +func Test_tableTopologicalSort(t *testing.T) { + pluginA := plugin.SubTaskMeta{ + Name: "A", + DependencyTables: []string{}, + ProductTables: []string{"_TOOL_TEST_TABLE"}, Review Comment: It would be better to simulate the situation I described in the previous review that multiple subtasks might produce records for the same table ########## backend/helpers/pluginhelper/subtaskmeta/sorter/table.go: ########## @@ -0,0 +1,74 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package sorter + +import ( + "github.com/apache/incubator-devlake/core/errors" + "github.com/apache/incubator-devlake/core/plugin" +) + +type TableSorter struct { + metas []*plugin.SubTaskMeta +} + +func NewTableSorter(metas []*plugin.SubTaskMeta) SubTaskMetaSorter { + return &TableSorter{metas: metas} +} + +func (d *TableSorter) Sort() ([]plugin.SubTaskMeta, errors.Error) { + return tableTopologicalSort(d.metas) +} + +func tableTopologicalSort(metas []*plugin.SubTaskMeta) ([]plugin.SubTaskMeta, errors.Error) { + constructedMetas := constructDependenciesByTable(metas) + return dependenciesTopologicalSort(constructedMetas) +} + +func constructDependenciesByTable(metas []*plugin.SubTaskMeta) []*plugin.SubTaskMeta { Review Comment: I believe so. Good job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
