chenggui53 commented on code in PR #5411: URL: https://github.com/apache/incubator-devlake/pull/5411#discussion_r1263774024
########## backend/helpers/pluginhelper/subtaskmeta/sorter/table.go: ########## @@ -0,0 +1,104 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package sorter + +import ( + "fmt" + "sort" + + "github.com/apache/incubator-devlake/core/errors" + "github.com/apache/incubator-devlake/core/plugin" +) + +type TableSorter struct { + metas []*plugin.SubTaskMeta +} + +func NewTableSorter(metas []*plugin.SubTaskMeta) SubTaskMetaSorter { + return &TableSorter{metas: metas} +} + +func (d *TableSorter) Sort() ([]plugin.SubTaskMeta, errors.Error) { + return tableTopologicalSort(d.metas) +} + +func tableTopologicalSort(metas []*plugin.SubTaskMeta) ([]plugin.SubTaskMeta, errors.Error) { + // 1. construct tmp data struct + subtaskNameMetaMap := make(map[string]*plugin.SubTaskMeta) + nameDependencyMap := make(map[string][]string) + nameProductMap := make(map[string][]string) + + productList := make([]string, 0) + for _, item := range metas { + subtaskNameMetaMap[item.Name] = item + nameDependencyMap[item.Name] = item.DependencyTables + + // check if subtask product same tables, which may cause cyclic error + for _, productItem := range item.ProductTables { + if contains(productList, productItem) { + return nil, errors.Convert(fmt.Errorf("duplicate product detected %s", productItem)) Review Comment: In fact, when I wrote here, I wondered whether there would be a sequence and conflict between different tasks operating on the same table, but unfortunately, I didn't think about this issue carefully and ask you for confirmation in time 😅 ########## backend/helpers/pluginhelper/subtaskmeta/sorter/table.go: ########## @@ -0,0 +1,104 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package sorter + +import ( + "fmt" + "sort" + + "github.com/apache/incubator-devlake/core/errors" + "github.com/apache/incubator-devlake/core/plugin" +) + +type TableSorter struct { + metas []*plugin.SubTaskMeta +} + +func NewTableSorter(metas []*plugin.SubTaskMeta) SubTaskMetaSorter { + return &TableSorter{metas: metas} +} + +func (d *TableSorter) Sort() ([]plugin.SubTaskMeta, errors.Error) { + return tableTopologicalSort(d.metas) +} + +func tableTopologicalSort(metas []*plugin.SubTaskMeta) ([]plugin.SubTaskMeta, errors.Error) { + // 1. construct tmp data struct + subtaskNameMetaMap := make(map[string]*plugin.SubTaskMeta) + nameDependencyMap := make(map[string][]string) + nameProductMap := make(map[string][]string) + + productList := make([]string, 0) + for _, item := range metas { + subtaskNameMetaMap[item.Name] = item + nameDependencyMap[item.Name] = item.DependencyTables + + // check if subtask product same tables, which may cause cyclic error + for _, productItem := range item.ProductTables { + if contains(productList, productItem) { + return nil, errors.Convert(fmt.Errorf("duplicate product detected %s", productItem)) Review Comment: In fact, when I wrote here, I wondered whether there would be a sequence and conflict between different tasks operating on the same table, but unfortunately, I didn't think about this issue carefully and ask you for confirmation in time 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
