klesh commented on code in PR #5411: URL: https://github.com/apache/incubator-devlake/pull/5411#discussion_r1263443688
########## backend/helpers/pluginhelper/subtaskmeta/sorter/table.go: ########## @@ -0,0 +1,104 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package sorter + +import ( + "fmt" + "sort" + + "github.com/apache/incubator-devlake/core/errors" + "github.com/apache/incubator-devlake/core/plugin" +) + +type TableSorter struct { + metas []*plugin.SubTaskMeta +} + +func NewTableSorter(metas []*plugin.SubTaskMeta) SubTaskMetaSorter { + return &TableSorter{metas: metas} +} + +func (d *TableSorter) Sort() ([]plugin.SubTaskMeta, errors.Error) { + return tableTopologicalSort(d.metas) +} + +func tableTopologicalSort(metas []*plugin.SubTaskMeta) ([]plugin.SubTaskMeta, errors.Error) { + // 1. construct tmp data struct + subtaskNameMetaMap := make(map[string]*plugin.SubTaskMeta) + nameDependencyMap := make(map[string][]string) + nameProductMap := make(map[string][]string) + + productList := make([]string, 0) + for _, item := range metas { + subtaskNameMetaMap[item.Name] = item + nameDependencyMap[item.Name] = item.DependencyTables + + // check if subtask product same tables, which may cause cyclic error + for _, productItem := range item.ProductTables { + if contains(productList, productItem) { + return nil, errors.Convert(fmt.Errorf("duplicate product detected %s", productItem)) Review Comment: It doesn't seem right because **records in a table may come from multiple subtasks**, for example the jira issue extractor [produces `Changelog`](https://github.com/apache/incubator-devlake/blob/927db42404f393557b26982761c70b06f462d0da/backend/plugins/jira/tasks/issue_extractor.go#L154) while [changelog collector](https://github.com/apache/incubator-devlake/blob/15afa46cf82ce479fb46757734636cf787faff69/backend/plugins/jira/tasks/issue_changelog_collector.go) + [changelog extractor](https://github.com/apache/incubator-devlake/blob/2d08ffaedc9debcb0be367bb84fa18592bb06cec/backend/plugins/jira/tasks/issue_changelog_extractor.go) also producing records to the same table due to Performance Consideration: If we could collect all changelogs from the issues, then we don't need to collect them from the Changelog API which is very very slow. Maybe we could just deduce and update the `Dependencies` for `SubtaskMeta` based on `ProductTables` and `DependencyTables` and reuse the existing `SubTaskMetaSorter`. 1. TableSort does nothing more than figure out what `Dependencies` should be 2. Sorting and Cyclic Detection can be done in `SubTaskMetaSorter` and one place only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
