ruanwenjun commented on code in PR #14797:
URL:
https://github.com/apache/dolphinscheduler/pull/14797#discussion_r1305542839
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java:
##########
@@ -32,7 +32,7 @@ public class NettyClientConfig {
* worker threads，default get machine cpus
*/
@Builder.Default
- private int workerThreads = Runtime.getRuntime().availableProcessors() * 2;
+ private int workerThreads = Runtime.getRuntime().availableProcessors() * 2
+ 1;
Review Comment:
SInce the thread will do some io task, and this is just an experience number.
You can get some from
https://github.com/brettwooldridge/HikariCP/wiki/About-Pool-Sizing#the-formula.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
