ruanwenjun commented on code in PR #14797:
URL:
https://github.com/apache/dolphinscheduler/pull/14797#discussion_r1306309046
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java:
##########
@@ -32,7 +32,7 @@ public class NettyClientConfig {
* worker threads，default get machine cpus
*/
@Builder.Default
- private int workerThreads = Runtime.getRuntime().availableProcessors() * 2;
+ private int workerThreads = Runtime.getRuntime().availableProcessors() * 2
+ 1;
Review Comment:
Thanks for point out this, I revert the count to 2 * core, keep the
framework default is better.
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java:
##########
@@ -32,7 +32,7 @@ public class NettyClientConfig {
* worker threads，default get machine cpus
*/
@Builder.Default
- private int workerThreads = Runtime.getRuntime().availableProcessors() * 2;
+ private int workerThreads = Runtime.getRuntime().availableProcessors() * 2
+ 1;
Review Comment:
Thanks for pointing out this, I revert the count to 2 * core, keeping the
framework default is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
