Radeity commented on code in PR #14797:
URL:
https://github.com/apache/dolphinscheduler/pull/14797#discussion_r1305807867
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java:
##########
@@ -32,7 +32,7 @@ public class NettyClientConfig {
* worker threads，default get machine cpus
*/
@Builder.Default
- private int workerThreads = Runtime.getRuntime().availableProcessors() * 2;
+ private int workerThreads = Runtime.getRuntime().availableProcessors() * 2
+ 1;
Review Comment:
Thanks for your reply, my confusion is whether add one, default work thread
in `EventLoopGroup` is `Runtime.getRuntime().availableProcessors() * 2`, it
just assumes ratio of io-time and cpu-time is 1:1, and work thread equals
`availableProcessors * (1 + 1/1)`.
And in HikariCP's wiki, `+1` is for `effective_spindle_count` which may
consider sth about disk IO.
Anyway, one more thread is not a big deal, just some personal confusion, if
you think this setting is a more experienced value, I'm totally OK with that :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
