ruanwenjun commented on code in PR #15031:
URL:
https://github.com/apache/dolphinscheduler/pull/15031#discussion_r1405125866
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public
SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
}
subWorkflowInstance =
processInstanceDao.queryById(subWorkflowInstance.getId());
if (subWorkflowInstance != null &&
subWorkflowInstance.getState().isFinished()) {
+ // update the varPool of sub workflow
+ taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());
Review Comment:
Yes, we need to set the variable in the task instance, since we didn't have
a good way in the engine, this should be refactor after `Master refactor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
