Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]

[via GitHub]

fuchanghai commented on PR #15031:
URL: 
https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1831615226

   > > hi @LiuShuangBJ I think that when creating the command of the 
subprocess, it is enough to pass the out type parameters of the parent process. 
As far as I know, the subprocess does not send custom parameters, so the 
localparams is Null. Maybe get the varPool of the task to fill it. cc 
@ruanwenjun @EricGao888 WDYT
   > > <img alt="image" width="971" 
src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjMwODcsIm5iZiI6MTcwMDkyMjc4NywicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0MzMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Njg2ZGVlZjA2NjhiZjQzYjRlYzY4MDk1YmFiNjJkYzMzNGRkNWFiY2ZhYjljZTJiMWU4MWE5NmU2MTBkNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xqiw3B6YprCnffk108gNYnMK9YBsMR_CqunBPJvtw_0";>
   > 
   > The right way is make sub task plugin can set in and out, otherwise it's 
difficult to know what should send to sub workflow, and what is the workflow 
will output, the logic should be same with other task plugin.
   
   
   
   > > hi @LiuShuangBJ I think that when creating the command of the 
subprocess, it is enough to pass the out type parameters of the parent process. 
As far as I know, the subprocess does not send custom parameters, so the 
localparams is Null. Maybe get the varPool of the task to fill it. cc 
@ruanwenjun @EricGao888 WDYT
   > > <img alt="image" width="971" 
src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjMwODcsIm5iZiI6MTcwMDkyMjc4NywicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0MzMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Njg2ZGVlZjA2NjhiZjQzYjRlYzY4MDk1YmFiNjJkYzMzNGRkNWFiY2ZhYjljZTJiMWU4MWE5NmU2MTBkNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xqiw3B6YprCnffk108gNYnMK9YBsMR_CqunBPJvtw_0";>
   > 
   > The right way is make sub task plugin can set in and out, otherwise it's 
difficult to know what should send to sub workflow, and what is the workflow 
will output, the logic should be same with other task plugin.
   
   hi @ruanwenjun I think subprocess's support for localParam is another issue. 
I think that even if subprocess does not support localParam, the varPool of the 
parent process instance can be passed to the subprocess instance. WDYT? cc 
@LiuShuangBJ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org