LiuShuangBJ commented on code in PR #15031:
URL:
https://github.com/apache/dolphinscheduler/pull/15031#discussion_r1405533542
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public
SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
}
subWorkflowInstance =
processInstanceDao.queryById(subWorkflowInstance.getId());
if (subWorkflowInstance != null &&
subWorkflowInstance.getState().isFinished()) {
+ // update the varPool of sub workflow
+ taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());
Review Comment:
I have more than 40 overall task nodes, so in order to visually represent
the overall process, except for the logical judgment node, my other nodes are
subProcess. The tasks in subProcess will have results output for the logical
nodes to make judgments. The logical node accepts the varPool of subProcess's
taskInstance, so the output parameters generated internally by subProcess are
updated here.
中文翻译:我整体的任务节点有40多个,所以为了直观地表示整体流程,除了逻辑判断节点之外,我其他的节点都是subProcess,在subProcess中的任务会有结果输出,供逻辑节点进行判断,而逻辑节点接受的是subProcess的taskInstance的varPool,所以在这里更新subProcess内部产生的输出参数
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public
SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
}
subWorkflowInstance =
processInstanceDao.queryById(subWorkflowInstance.getId());
if (subWorkflowInstance != null &&
subWorkflowInstance.getState().isFinished()) {
+ // update the varPool of sub workflow
+ taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());
Review Comment:
I have more than 40 overall task nodes, so in order to visually represent
the overall process, except for the logical judgment node, my other nodes are
subProcess. The tasks in subProcess will have results output for the logical
nodes to make judgments. The logical node accepts the varPool of subProcess's
taskInstance, so the output parameters generated internally by subProcess are
updated here.
中文翻译:我整体的任务节点有40多个,所以为了直观地表示整体流程,除了逻辑判断节点之外,我其他的节点都是subProcess,在subProcess中的任务会有结果输出,供逻辑节点进行判断,而逻辑节点接受的是subProcess的taskInstance的varPool,所以在这里更新subProcess内部产生的输出参数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
