yangyanh commented on PR #15645:
URL: 
https://github.com/apache/dolphinscheduler/pull/15645#issuecomment-1977861335

   If you use -jar, you need to specify the entry class, but the page cannot 
specify the entry class on the configuration page when you select the jar type
   
   
   
   
   ------------------ 原始邮件 ------------------
   发件人: "Wenjun ***@***.***>; 
   发送时间: 2024年3月5日(星期二) 上午10:33
   收件人: ***@***.***>; 
   抄送: ***@***.***>; ***@***.***>; 
   主题: Re: [apache/dolphinscheduler] fixed The jar type of java task shell 
script error (PR #15645)
   
   
   
   
   
    
   @ruanwenjun requested changes on this pull request.
    
    
   In 
dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java:
    > @@ -183,9 +184,8 @@ protected String buildJarCommand() {          
StringBuilder builder = new StringBuilder();          
builder.append(getJavaCommandPath())                  .append("java").append(" 
") -                .append(buildResourcePath()).append(" ") +                
.append(buildExtDirs()).append(" ")  
   Can we refactor this, use -cp rather than -jar.
    $JAVA_HOME/bin/java $JVM_ARGS \   -cp "$taskInstanceWorkingPath" \   
Main.class  
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you were mentioned.Message ID: ***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to