ruanwenjun commented on code in PR #15645:
URL:
https://github.com/apache/dolphinscheduler/pull/15645#discussion_r1515596966
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java:
##########
@@ -183,9 +184,8 @@ protected String buildJarCommand() {
StringBuilder builder = new StringBuilder();
builder.append(getJavaCommandPath())
.append("java").append(" ")
- .append(buildResourcePath()).append(" ")
+ .append(buildExtDirs()).append(" ")
Review Comment:
> It seems that -jar cannot work with -cp together,-jar cannot get -cp's
libraries,Is your shell worked success？have you test your shell script?
Yes, -jar can not work with -cp.
Once we use -jar then the jar should be a fat jar, the better way is to add
ext jar by set Class-Path at `MANIFEST.MF`.
So Can we use -cp with entry class(add a new param) rather than -jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
