ruanwenjun commented on code in PR #15645:
URL:
https://github.com/apache/dolphinscheduler/pull/15645#discussion_r1512207668
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java:
##########
@@ -183,9 +184,8 @@ protected String buildJarCommand() {
StringBuilder builder = new StringBuilder();
builder.append(getJavaCommandPath())
.append("java").append(" ")
- .append(buildResourcePath()).append(" ")
+ .append(buildExtDirs()).append(" ")
Review Comment:
Yes，I just find we cannot set entry class......
So we only support fat jar, this is sad.
So the final command should look like
```
$JAVA_HOME/bin/java -jar xx.jar $JVM_ARGS
```
Can we remove `-Djava.ext.dirs`, it seems not a good idea to use this param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
