ZhongJinHacker commented on PR #15741: URL: https://github.com/apache/dolphinscheduler/pull/15741#issuecomment-2009570063
to executeTask method's logic, I can understand the logic intention. Only executeTask success will return true, and if write the taskInstance to db fail or throw Exception will return false. But in the follow code:  it is incorrect. the log ("Submit standby task: {} failed")also can express this. when when taskInstance write to db unsuccessfully.`processService.submitTask` will return false, it let into the code block. and return `true` . this incorrect boolean value will cause the out layer caller who call `executeTask` method think the task is executed successfully, but in the fact, the task do not write into database's table -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
