rickchengx commented on code in PR #15741:
URL:
https://github.com/apache/dolphinscheduler/pull/15741#discussion_r1538560909
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -908,7 +908,7 @@ private boolean executeTask(TaskInstance taskInstance) {
// todo: remove this method
if (!processService.submitTask(workflowInstance, taskInstance)) {
log.error("Submit standby task: {} failed",
taskInstance.getName());
- return true;
+ return false;
Review Comment:
It seems that it should return false if it submits to DB failed, not sure if
there are other considerations.
but there is also a todo here. cc @ruanwenjun
will we remove this method or fix this logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
