ruanwenjun commented on code in PR #15741:
URL:
https://github.com/apache/dolphinscheduler/pull/15741#discussion_r1545721563
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -908,7 +908,7 @@ private boolean executeTask(TaskInstance taskInstance) {
// todo: remove this method
if (!processService.submitTask(workflowInstance, taskInstance)) {
log.error("Submit standby task: {} failed",
taskInstance.getName());
- return true;
+ return false;
Review Comment:
It's better not to change this logic unless we find a bug related to this
issue. When the workflow instance is READY_STOP, it will also submit the task,
but will return false here to avoid dispatch the task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
