pegasas commented on code in PR #15922:
URL:
https://github.com/apache/dolphinscheduler/pull/15922#discussion_r1580535450
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -794,6 +794,97 @@ alert:
labels: {}
# -- serviceMonitor.annotations ServiceMonitor annotations
annotations: {}
+ configmap:
Review Comment:
> I don't think we need to put everything into values. In the future,
probably we will have separated configmaps for api server, master server and
worker server. Why not put them directly in
`configmap-dolphinscheduler-alert.yam`?
it seems like 2 points?
1.not put everything into values, i agree. maybe we can choose some
important items here.
2.because we can not just put application.yaml into cm but other config
items. i think it may be more extendable if configured in values.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
