pegasas commented on code in PR #15922:
URL:
https://github.com/apache/dolphinscheduler/pull/15922#discussion_r1580561872
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -794,6 +794,97 @@ alert:
labels: {}
# -- serviceMonitor.annotations ServiceMonitor annotations
annotations: {}
+ configmap:
Review Comment:
> We could put application.yaml into configmap, and make some important
items of application.yaml as variables and access them through `values.yaml`.
For example api server, alert server and master server all need access to db
and there are db related configs in the `application.yaml` for all of them. So
you may put db related configs in values.yaml, and share those configs across
different `application.yaml` for alert server, api server and master server.
The same for registry related configs.
I got your point.
will apply these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
