SbloodyS commented on code in PR #16715:
URL:
https://github.com/apache/dolphinscheduler/pull/16715#discussion_r1808020057
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionLogMapper.xml:
##########
@@ -45,10 +45,11 @@
<select id="queryByDefinitionCodeAndVersion"
resultType="org.apache.dolphinscheduler.dao.entity.WorkflowDefinitionLog">
select
- <include refid="baseSql"/>
- from t_ds_workflow_definition_log
- where code = #{code}
- and version = #{version}
+ pd.*, p.name as project_name
+ from t_ds_workflow_definition_log pd
+ left join t_ds_project p ON pd.project_code = p.code
Review Comment:
Please split query project into a divided query instead of using `left join`
query to improve performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
