Re: [PR] [Fix-16705] [Built-in Parameter] Fix project name and definition name variable parameter not resolved [dolphinscheduler]

Mon, 21 Oct 2024 20:03:12 -0700 


sdhzwc commented on code in PR #16715:
URL: 
https://github.com/apache/dolphinscheduler/pull/16715#discussion_r1809781436


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/expand/CuringParamsServiceImpl.java:
##########
@@ -276,7 +279,8 @@ public Map<String, Property> 
paramParsingPreparation(@NonNull TaskInstance taskI
      */
     private Map<String, String> setBuiltInParamsMap(@NonNull TaskInstance 
taskInstance,
                                                     WorkflowInstance 
workflowInstance,
-                                                    String timeZone) {
+                                                    String timeZone,

Review Comment:
   > Using Project rather than WorkflowDefinition here.
   
   
![image](https://github.com/user-attachments/assets/3f159386-2ff4-483f-a4e2-62959ed1cdaa)
   Add in workflowInstance, so how about this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to