sdhzwc commented on code in PR #16715:
URL:
https://github.com/apache/dolphinscheduler/pull/16715#discussion_r1810042768
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/AbstractCommandHandler.java:
##########
@@ -106,6 +111,10 @@ protected void assembleWorkflowDefinition(
checkArgument(workflowDefinition != null,
"Cannot find the WorkflowDefinition: [" +
workflowDefinitionCode + ":" + workflowDefinitionVersion
+ "]");
+ Project project =
projectDao.queryByCode(workflowDefinition.getProjectCode());
+ if (project != null) {
+ workflowDefinition.setProjectName(project.getName());
+ }
Review Comment:
> `WorkflowDefinition` is a DO, please don't add field to this which doesn't
exist in db, this will make it hard to judge which and when it is not null.
>
> It's better to assemble project into `WorkflowExecuteContext`.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
