ruanwenjun commented on code in PR #16790:
URL:
https://github.com/apache/dolphinscheduler/pull/16790#discussion_r1855204588
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/dynamic/DynamicLogicTask.java:
##########
@@ -100,28 +102,27 @@ public DynamicLogicTask(TaskExecutionContext
taskExecutionContext,
this.taskInstance =
taskInstanceDao.queryById(taskExecutionContext.getTaskInstanceId());
}
- @Override
- public AsyncTaskExecuteFunction getAsyncTaskExecuteFunction() throws
MasterTaskExecuteException {
- List<Map<String, String>> parameterGroup = generateParameterGroup();
-
- if (parameterGroup.size() >
taskParameters.getMaxNumOfSubWorkflowInstances()) {
- log.warn("the number of sub process instances [{}] exceeds the
maximum limit [{}]", parameterGroup.size(),
- taskParameters.getMaxNumOfSubWorkflowInstances());
- parameterGroup = parameterGroup.subList(0,
taskParameters.getMaxNumOfSubWorkflowInstances());
- }
-
- // if already exists sub process instance, do not generate again
- List<WorkflowInstance> existsSubWorkflowInstanceList =
-
subWorkflowService.getAllDynamicSubWorkflow(workflowInstance.getId(),
taskInstance.getTaskCode());
- if (CollectionUtils.isEmpty(existsSubWorkflowInstanceList)) {
- generateSubWorkflowInstance(parameterGroup);
- } else {
- resetProcessInstanceStatus(existsSubWorkflowInstanceList);
- }
- return new DynamicAsyncTaskExecuteFunction(taskExecutionContext,
workflowInstance, taskInstance, this,
- commandMapper,
- subWorkflowService, taskParameters.getDegreeOfParallelism());
- }
+ // public AsyncTaskExecuteFunction getAsyncTaskExecuteFunction() throws
MasterTaskExecuteException {
+ // List<Map<String, String>> parameterGroup = generateParameterGroup();
+ //
+ // if (parameterGroup.size() >
dynamicParameters.getMaxNumOfSubWorkflowInstances()) {
+ // log.warn("the number of sub process instances [{}] exceeds the maximum
limit [{}]", parameterGroup.size(),
+ // dynamicParameters.getMaxNumOfSubWorkflowInstances());
+ // parameterGroup = parameterGroup.subList(0,
dynamicParameters.getMaxNumOfSubWorkflowInstances());
+ // }
+ //
+ // // if already exists sub process instance, do not generate again
+ // List<WorkflowInstance> existsSubWorkflowInstanceList =
+ // subWorkflowService.getAllDynamicSubWorkflow(workflowInstance.getId(),
taskInstance.getTaskCode());
+ // if (CollectionUtils.isEmpty(existsSubWorkflowInstanceList)) {
+ // generateSubWorkflowInstance(parameterGroup);
+ // } else {
+ // resetProcessInstanceStatus(existsSubWorkflowInstanceList);
+ // }
+ // return new DynamicAsyncTaskExecuteFunction(taskExecutionContext,
workflowInstance, taskInstance, this,
+ // commandMapper,
+ // subWorkflowService, dynamicParameters.getDegreeOfParallelism());
+ // }
Review Comment:
We can remove this class after #16591, so I don't fix the exist problem in
this class.
##########
docs/docs/zh/guide/upgrade/incompatible.md:
##########
@@ -32,4 +32,5 @@
* 废弃从 1.x 至 2.x 的升级代码
([#16543])(https://github.com/apache/dolphinscheduler/pull/16543)
* 移除 `数据质量` 模块
([#16794])(https://github.com/apache/dolphinscheduler/pull/16794)
* 在`application.yaml`中移除`registry-disconnect-strategy`配置
([#16821])(https://github.com/apache/dolphinscheduler/pull/16821)
+*
在worker`application.yaml`中移除exec-threads，使用physical-task-config替代;在master`application.yaml`中移除master-async-task-executor-thread-pool-size使用logic-task-config替代
([#16790])(https://github.com/apache/dolphinscheduler/pull/16790)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
