ruanwenjun commented on code in PR #16790:
URL:
https://github.com/apache/dolphinscheduler/pull/16790#discussion_r1863046587
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/lifecycle/TaskLifecycleEventType.java:
##########
@@ -38,6 +38,10 @@ public enum TaskLifecycleEventType implements
ILifecycleEventType {
* The task instance is running at the target executor server.
*/
RUNNING,
+ /**
+ * The task instance's runtime context changed.
+ */
+ RUNTIME_CONTEXT_CHANGED,
Review Comment:
Import a new event type here can avoid we have multiple event schema for an
event type. This event type represent the task runtime context changed, will
not affect the state, if we use running event and finish event, we need to add
runtime context info into these events, once runtime context changed, we will
need to change these events.
And it's hard to explain why some running events have runtime context but
some not.
So split the runtime context to a single event type can avoid these, this
event type doesn't affect the lifecycle of a task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
