ruanwenjun commented on code in PR #16790:
URL:
https://github.com/apache/dolphinscheduler/pull/16790#discussion_r1863037920
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/dynamic/DynamicAsyncTaskExecuteFunction.java:
##########
@@ -143,7 +142,7 @@ private void setOutputParameters() {
List<Property> taskPropertyList = new
ArrayList<>(JSONUtils.toList(taskInstance.getVarPool(), Property.class));
taskPropertyList.add(property);
-
logicTask.getTaskParameters().setVarPool(JSONUtils.toJsonString(taskPropertyList));
+ //
logicTask.getTaskParameters().setVarPool(JSONUtils.toJsonString(taskPropertyList));
Review Comment:
`TaskParameters` doesn't exposed to outside, since Dynamic task will be
removed by https://github.com/apache/dolphinscheduler/pull/16842, so this pr
doesn't fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
