ruanwenjun commented on code in PR #17320: URL: https://github.com/apache/dolphinscheduler/pull/17320#discussion_r2192232097
########## deploy/kubernetes/dolphinscheduler/README.md: ########## @@ -141,6 +141,7 @@ Please refer to the [Quick Start in Kubernetes](../../../docs/docs/en/guide/inst | conf.common."login.user.keytab.username" | string | `"[email protected]"` | login user from keytab username | | conf.common."ml.mlflow.preset_repository" | string | `"https://github.com/apache/dolphinscheduler-mlflow"` | mlflow task plugin preset repository | | conf.common."ml.mlflow.preset_repository_version" | string | `"main"` | mlflow task plugin preset repository version | +| conf.common."process.status.check.delay" | int | `5` | The delay before checking the shell process status after termination (in seconds) | Review Comment: I think it's better used for waiting the soft kill result. If it timeout then hard kill. This seems make little sense if only wait the process exit. If it doesn't exit, then you should not return. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
