njnu-seafish commented on code in PR #17320: URL: https://github.com/apache/dolphinscheduler/pull/17320#discussion_r2193781528
########## deploy/kubernetes/dolphinscheduler/README.md: ########## @@ -141,6 +141,7 @@ Please refer to the [Quick Start in Kubernetes](../../../docs/docs/en/guide/inst | conf.common."login.user.keytab.username" | string | `"[email protected]"` | login user from keytab username | | conf.common."ml.mlflow.preset_repository" | string | `"https://github.com/apache/dolphinscheduler-mlflow"` | mlflow task plugin preset repository | | conf.common."ml.mlflow.preset_repository_version" | string | `"main"` | mlflow task plugin preset repository version | +| conf.common."process.status.check.delay" | int | `5` | The delay before checking the shell process status after termination (in seconds) | Review Comment: // 1. Try to terminate gracefully (SIGINT) boolean gracefulKillSuccess = sendKillSignal("SIGINT", pids, request.getTenantCode()); if (gracefulKillSuccess) { log.info("Successfully killed process tree using SIGINT, processId: {}", processId); return true; } The key issue is that the soft kill returns success, but the physical process is not actually killed, so we need to add a check process status logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
