njnu-seafish commented on code in PR #17320: URL: https://github.com/apache/dolphinscheduler/pull/17320#discussion_r2193823938
########## deploy/kubernetes/dolphinscheduler/README.md: ########## @@ -141,6 +141,7 @@ Please refer to the [Quick Start in Kubernetes](../../../docs/docs/en/guide/inst | conf.common."login.user.keytab.username" | string | `"[email protected]"` | login user from keytab username | | conf.common."ml.mlflow.preset_repository" | string | `"https://github.com/apache/dolphinscheduler-mlflow"` | mlflow task plugin preset repository | | conf.common."ml.mlflow.preset_repository_version" | string | `"main"` | mlflow task plugin preset repository version | +| conf.common."process.status.check.delay" | int | `5` | The delay before checking the shell process status after termination (in seconds) | Review Comment: > I think it's better used for waiting the soft kill result. If it timeout then hard kill. This seems make little sense if only wait the process exit. If it doesn't exit, then you should not return. 在实际开发和运维中，不要一上来就用 SIGKILL，这会剥夺进程清理资源的机会。推荐的做法是： 先发 SIGINT，等待一定时间（比如 5~10 秒），检查进程状态 如果未退出，再发送SIGTERM，等待一定时间（比如 5~10 秒），检查进程状态 如果未退出，再发 SIGKILL。 一个关键点：即使 SIGINT成功返回了，进程也可能还在运行，所以必须加上检查逻辑（check logic），确认进程是否真的退出 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
