yangyichao-mango commented on a change in pull request #3186:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3186#discussion_r453150992



##########
File path: 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
##########
@@ -51,6 +48,8 @@ private NetUtils() {
 
     private static volatile String HOST_ADDRESS;
 
+    private static  String DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE = 
"dolphin.scheduler.network.interface.preferred";
+

Review comment:
       Hi,
   
   Is it better to move `DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE` to 
`Constants.java`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to