yangyichao-mango commented on a change in pull request #3186:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3186#discussion_r453202785
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
##########
@@ -206,4 +215,8 @@ public static boolean
ignoreNetworkInterface(NetworkInterface networkInterface)
|| !networkInterface.isUp();
}
+ public static boolean isSpecifyNetworkInterface(NetworkInterface
networkInterface) {
+ String preferredNetworkInterface =
System.getProperty(DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE);
+ return Objects.equals(networkInterface.getDisplayName(),
preferredNetworkInterface);
+ }
Review comment:
> * Hello, this is exclusive to net, other business is not involved, so
I think it is better to achieve here,how do you think？
Hi,
I think it is better not to add the `isSpecifyNetworkInterface` in
`findNetworkInterface` of `utils`, but I find there is only one call of
`findNetworkInterface`, so I don't think of a better place to add this at
present.
I think we can think about the implement scheme again later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
