yangyichao-mango commented on a change in pull request #3186:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3186#discussion_r453150925
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
##########
@@ -206,4 +215,8 @@ public static boolean
ignoreNetworkInterface(NetworkInterface networkInterface)
|| !networkInterface.isUp();
}
+ public static boolean isSpecifyNetworkInterface(NetworkInterface
networkInterface) {
+ String preferredNetworkInterface =
System.getProperty(DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE);
+ return Objects.equals(networkInterface.getDisplayName(),
preferredNetworkInterface);
+ }
Review comment:
Hi,
Good job,
`Utils` should be used as a tool class and it is better not to involve
business process.
Is it better to implement this part in the business process class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
