liang-wenjie commented on PR #18464: URL: https://github.com/apache/dolphinscheduler/pull/18464#issuecomment-5261103860
Thanks for the detailed review, @SbloodyS. I have addressed the latest invalid-policy feedback in \\1831d55e5\\ (\\ ix(api): reject invalid missed fire policy\\). What changed: - Explicit \\ ull\\ and unrecognized \\missedFirePolicy\\ values are now rejected with \\REQUEST_PARAMS_NOT_VALID_ERROR\\ for both create and update. - Omitted \\missedFirePolicy\\ keeps the previous compatible behavior: create uses the default \\FIRE_ALL_MISSED\\, and update preserves the existing stored policy. - Added regression coverage for explicit null and unknown enum values on both insert and update, while keeping the existing omitted-field tests. Local verification: - \\SchedulerServiceTest\\: 14 tests passed - \\spotless:check -pl dolphinscheduler-api\\: passed Could you please re-review and clear the previous changes-requested review when convenient? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
