liang-wenjie commented on PR #18464: URL: https://github.com/apache/dolphinscheduler/pull/18464#issuecomment-5204077067
Addressed the latest review feedback in 060743fd2: - removed the redundant SchedulerServiceImpl default-policy helper; - changed CronScheduleBuilderFactory and all implementations to accept Schedule and configure the timezone internally; - added timezone assertions to CronScheduleBuilderFactoryTest; - documented the 3.5.0 missed_fire_policy schema change in the English and Chinese incompatible guides; - moved the upgrade DDL from the incorrect 3.3.2_schema post files into the current 3.5.0_schema MySQL/PostgreSQL scripts, which addresses the historical-version schema-check failures. Local verification: - spotless:check for the changed backend modules: passed - CronScheduleBuilderFactoryTest: 4 tests passed - git diff --check: passed The previous dead-link failure is unrelated to this PR content: lychee v0.24.0 rejects the existing repository setting include_fragments = false (it expects a string or table). The milestone-label check still requires a maintainer-added milestone/type label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
