liang-wenjie commented on code in PR #18464:
URL:
https://github.com/apache/dolphinscheduler/pull/18464#discussion_r3728388507
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java:
##########
@@ -401,6 +403,10 @@ public List<String> previewSchedule(User loginUser, String
schedule) {
.collect(Collectors.toList());
}
+ private ScheduleMissedFirePolicy
defaultMissedFirePolicy(ScheduleMissedFirePolicy missedFirePolicy) {
+ return missedFirePolicy == null ?
ScheduleMissedFirePolicy.FIRE_ALL_MISSED : missedFirePolicy;
+ }
Review Comment:
Removed the redundant fallback helper. SchedulerServiceImpl now uses
ScheduleParam#getMissedFirePolicy directly, since ScheduleParam already
initializes the default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
