michaellx1057 commented on PR #18645: URL: https://github.com/apache/dolphinscheduler/pull/18645#issuecomment-5712171590
> The current code looks too messy and feels overly AI-driven, making it difficult to tell exactly what problem it’s meant to solve. An event-driven approach might be a better solution. The `WorkflowSerialCoordinator` only needs to ensure that all internal threads have finished its work before the `close` method returns. The higher-level `AbstractHAServer` is responsible for executing state-change events and controlling the active/ @ruanwenjun Thanks for the suggestions. I've updated the implementation to use a single election worker and simplified the lifecycle logic. Demotion and normal Master shutdown now share the same cleanup path: both coordinators are asked to stop before we wait for either worker to finish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
