ruanwenjun commented on code in PR #18694:
URL:
https://github.com/apache/dolphinscheduler/pull/18694#discussion_r4244285293
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/LogicTaskExecutor.java:
##########
@@ -24,12 +24,16 @@
import org.apache.dolphinscheduler.task.executor.TaskExecutorState;
import org.apache.dolphinscheduler.task.executor.TaskExecutorStateMappings;
+import java.util.concurrent.TimeUnit;
+
import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;
@Slf4j
public class LogicTaskExecutor extends AbstractTaskExecutor {
+ private static final long MIN_STATE_TRACK_INTERVAL_MILLIS =
TimeUnit.SECONDS.toMillis(1);
Review Comment:
```suggestion
private static final long MIN_STATE_TRACK_INTERVAL_MILLIS =
TimeUnit.SECONDS.toMillis(10);
```
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/LogicTaskExecutor.java:
##########
@@ -66,6 +75,7 @@ public void pause() {
// if the status is initialized, then we can directly change to paused
if (logicTask != null) {
logicTask.pause();
+ resetStateTrackTime();
Review Comment:
It's best not to reset; I'm worried it might cause some bugs involving
infinite loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
