github-advanced-security[bot] commented on code in PR #18694:
URL:
https://github.com/apache/dolphinscheduler/pull/18694#discussion_r4255382494
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/dependent/DependentLogicTask.java:
##########
@@ -51,8 +63,26 @@
WorkflowInstanceDao workflowInstanceDao,
IWorkflowExecution workflowExecution,
TaskInstanceContextDao taskInstanceContextDao) {
+ this(taskExecutionContext, projectDao, workflowDefinitionDao,
taskDefinitionDao, taskInstanceDao,
+ workflowInstanceDao, workflowExecution,
taskInstanceContextDao, System::nanoTime);
+ }
+
+ @VisibleForTesting
+ DependentLogicTask(TaskExecutionContext taskExecutionContext,
+ ProjectDao projectDao,
+ WorkflowDefinitionDao workflowDefinitionDao,
+ TaskDefinitionDao taskDefinitionDao,
+ TaskInstanceDao taskInstanceDao,
+ WorkflowInstanceDao workflowInstanceDao,
+ IWorkflowExecution workflowExecution,
Review Comment:
## CodeQL / Useless parameter
The parameter 'workflowExecution' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5876)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
