ruanwenjun commented on code in PR #18694:
URL:
https://github.com/apache/dolphinscheduler/pull/18694#discussion_r4245555121
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/LogicTaskExecutor.java:
##########
@@ -66,6 +75,7 @@ public void pause() {
// if the status is initialized, then we can directly change to paused
if (logicTask != null) {
logicTask.pause();
+ resetStateTrackTime();
Review Comment:
Under the current changes, there is still a possibility of long wait times,
depending on when `getTaskExecutionStateCheckInterval` is called.
To better handle this issue, a better approach might be to use a fixed
polling interval at the framework level to check the TaskExecutor’s status, and
then, within the `LogicTask`, use the interval specified in the task parameters
to determine whether to trigger the underlying query or simply return the
cached status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
