ruanwenjun commented on PR #18718: URL: https://github.com/apache/dolphinscheduler/pull/18718#issuecomment-6570846261
Thanks for the [review](https://github.com/apache/dolphinscheduler/pull/18718#pullrequestreview-5710580361). Addressed all three points in [2aaf1d48f0](https://github.com/apache/dolphinscheduler/commit/2aaf1d48f0935c558070f2545e055f06f8f1fd72): 1. Removed the legacy creator checks from workflow-definition and schedule deletion. The corresponding project permission checks (`DEVELOP` / `MANAGE_SCHEDULES`) and existing state/dependency constraints are retained. Added positive regression tests for non-owner members and updated the obsolete ownership assertions. 2. Administrator-only datasource management is intentional. Updated both language versions of the security model, permission guide and 3.5.0 incompatible-change notes to explicitly cover creation, global listing, details/configuration, updates, connection tests and deletion. Ordinary users can still select and use datasources granted to their projects within their project permissions. 3. Normalized `K8sNamespaceMapper.xml` to LF without changing its SQL. `git diff --check upstream/dev...HEAD` now passes for the full cumulative PR diff. Both new regression tests failed before the fix. After the fix, all 112 focused tests passed, along with Root/API Spotless, documentation image checks and local-link checks. CI for this commit is still queued/running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
