ruanwenjun commented on PR #18718: URL: https://github.com/apache/dolphinscheduler/pull/18718#issuecomment-6631084093
Thanks for the [review](https://github.com/apache/dolphinscheduler/pull/18718#pullrequestreview-5768185604). Updated in [34a4f3b182](https://github.com/apache/dolphinscheduler/commit/34a4f3b1820cb42be000140b003bb206f82e90f1): 1. Audit details now contain only the target and before/after state; operator, project and action use the existing audit columns. Widened `detail` to `varchar(2048)` in the fresh schemas and MySQL/PostgreSQL upgrades, and aligned MySQL `model_name` with the existing 255-character columns. Database tests cover normal keys, 255-character keys and JSON escaping, with exact round-trip and parseability assertions for fresh and upgraded schemas. 2. Failed/suspended recovery now reuses the execution authorization path before submitting the command. The parent uses its instance's recorded definition version and execution settings; referenced children are recursively checked using their current definitions and owning projects, including `EXECUTE`, resource grants and inherited execution settings. We kept one API policy rather than branching on bound child instances. Both language guides now explicitly state that current child-definition changes, moves or revoked grants can reject historical recovery. Master runtime behavior is unchanged. 3. Updated [DSIP-104](https://github.com/apache/dolphinscheduler/issues/17923) to describe the four-permission model explicitly: publishing belongs to `DEVELOP`, and schedule management belongs to `EXECUTE`. The issue also documents the resulting permission scope and recovery policy. Validation: 41 focused API tests passed, including recovery rejection/success and H2 authorization/audit transaction tests. Two real MySQL/PostgreSQL schema/upgrade tests passed. Spotless, documentation image checks and `git diff --check` passed. Full API/browser E2E suites were not rerun; CI for this commit is not yet verified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
