SbloodyS commented on code in PR #10217: URL: https://github.com/apache/dolphinscheduler/pull/10217#discussion_r885285721
########## dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/main/resources/docker-compose.yml: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: "3" + +services: + mlflow-model: + image: "${imageName}" + ports: + - "${deployPort}:8080" + deploy: + resources: + limits: + cpus: "${cpuLimit}" + memory: "${memoryLimit}" Review Comment: > I think we should add healthcheck here and use some methods such as `https://www.testcontainers.org/` that can be monitored. So that we can ensure the health of the container before performing subsequent operations. Currently ```E2E``` using this package to start ```docker container``` from ```docker-compose.yaml``` and monitor it and destory it after all is done. From the perspective of users using DS. Users do not pay attention to the task type. What they expect is that all task types have the same functionality, including stopping tasks. If the start, stop and running status of containers are not monitored, it is likely that abnormal debug caused by user environment problems will be very difficult. At the same time, it may also cause many orphan containers to affect the user's docker environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
