SbloodyS commented on code in PR #10217: URL: https://github.com/apache/dolphinscheduler/pull/10217#discussion_r885439972
########## dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/main/resources/docker-compose.yml: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: "3" + +services: + mlflow-model: + image: "${imageName}" + ports: + - "${deployPort}:8080" + deploy: + resources: + limits: + cpus: "${cpuLimit}" + memory: "${memoryLimit}" Review Comment: I'm not familiar about ML. I'm just asking the usual questions questions. The command ```docker run``` sometimes would not throw exception if the docker container successfully start but healthcheck failed. After several runs it may cause many orphan containers in the user's host machine and it can't be known by ds or removed by ds. The users can only view the corresponding tasks through ```SSH``` on the worker's machine. Does this lose some features of DS? @jieguangzhou ########## dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/main/resources/docker-compose.yml: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: "3" + +services: + mlflow-model: + image: "${imageName}" + ports: + - "${deployPort}:8080" + deploy: + resources: + limits: + cpus: "${cpuLimit}" + memory: "${memoryLimit}" Review Comment: I'm not familiar about ML. I'm just asking the usual questions. The command ```docker run``` sometimes would not throw exception if the docker container successfully start but healthcheck failed. After several runs it may cause many orphan containers in the user's host machine and it can't be known by ds or removed by ds. The users can only view the corresponding tasks through ```SSH``` on the worker's machine. Does this lose some features of DS? @jieguangzhou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
