kezhenxu94 commented on code in PR #10217:
URL: https://github.com/apache/dolphinscheduler/pull/10217#discussion_r888955693
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowConstants.java:
##########
@@ -86,9 +88,17 @@ private MlflowConstants() {
public static final String MLFLOW_BUILD_DOCKER = "mlflow models
build-docker -m %s -n %s --enable-mlserver";
-
public static final String DOCKER_RREMOVE_CONTAINER = "docker rm -f %s";
public static final String DOCKER_RUN = "docker run --name=%s -p=%s:8080
%s";
+ public static final String DOCKER_COMPOSE_RUN = "docker compose up -d";
+
+ public static final String DOCKER_COMPOSE_CANCEL = "docker compose down";
+
+ public static final String SET_DOCKER_COMPOSE_ENV = "export
imageName=%s\n" +
+ "export deployPort=%s\n" +
+ "export cpuLimit=%s\n" +
+ "export memoryLimit=%s";
Review Comment:
Generally environment names should be all capitalized, and please add
reasonable prefix (like `DS_TASK_MLFLOW_`) to avoid possible conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
