[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10373: [Feature-6758][Task] Add limit resource usage for tasks base on cgroup

Tue, 07 Jun 2022 21:04:10 -0700 


ruanwenjun commented on code in PR #10373:
URL: https://github.com/apache/dolphinscheduler/pull/10373#discussion_r891896369


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/OSUtils.java:
##########
@@ -68,6 +68,15 @@ public static boolean isWindows() {
         return getOSName().startsWith("Windows");
     }
 
+    /**
+     * whether is linux
+     *
+     * @return true if linux
+     */
+    public static boolean isLinux() {
+        return !isWindows() && !isMacOS();
+    }

Review Comment:
   It’s better to directly use `SystemUtils.IS_OS_LINUX`, this may need to add 
`commons.lang3` in task api module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to